Add command to open a resource in the browser #1846
Merged
+351
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnester
approved these changes
Oct 23, 2024
bundle/resources/keys.go
Outdated
|
|
||
| // First try to find the resource by key alone. | ||
| if res, ok := keyOnly[key]; ok { | ||
| if len(res) == 1 { |
There was a problem hiding this comment.
Shall we add the case if len > 1 then we return the error that the resource is ambiguous?
There was a problem hiding this comment.
pietern
changed the title
andrewnester
approved these changes
Oct 24, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
## Changes As of #1846 we have a generalized package for doing resource lookups and completion. This change updates the run command to use this instead of more specific code under `bundle/run`. ## Tests * Unit tests pass * Manually confirmed that completion and prompting works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This builds on the functionality added in #1731 that produces a URL for every resource.
Adds
bundle/resourcespackage to deal with resource lookups and command completion. The new functionality is similar to the lookup and command completion functionality located inbundle/run. It differs in that it doesn't gracefully deal with ambiguous references to resources, now that we explicitly validate this doesn't occur in the bundle configuration. It still allows resources to be looked up with their fully qualified key,<plural type>.<key>.Tests
bundle openprompts, accepts a key argument, and opens a browser